-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-amplify-react-native): Add withOAuth HOC for Cognito Hosted UI #2665
feat(aws-amplify-react-native): Add withOAuth HOC for Cognito Hosted UI #2665
Conversation
Look at the diff with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes for maintenance, otherwise looking great!
a4ae999
to
dfbb767
Compare
"amazon-cognito-auth-js no longer needs them
9d27dab
to
36c6549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our 1:1 code review and testing, this all looks good and is working great. Let's please follow up on the docs around using React Native links and tying this to the URLs entered into the Cognito console.
Are I don't think this affects anything, but you get a warning now when installing.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.