aws-amplify-react-native - withOAuth HOC - Loading State #3021
Labels
Auth
Related to Auth components/category
feature-request
Request a new feature
needs-discussion
Used for internal discussions
Comments
jessedoyle
changed the title
was-amplify-react-native - withOAuth HOC - Loading State
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
Apr 5, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `true`. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
Apr 5, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `true`. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
Apr 6, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `true`. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
elorzafe
added
Auth
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
Apr 8, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `true`. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
May 6, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `true`. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
jessedoyle
pushed a commit
to jessedoyle/amplify-js
that referenced
this issue
May 10, 2019
* Add a `loading` prop to the `withOAuth` higher order component that defaults to `false`. * Once the component is mounted, set the loading state to true. * Once the amplify session has been created, the `loading` prop is set to `false`. * This allows wrapped components to make decisions and display animations to users when the HOC is loading. * Resolves aws-amplify#3021
jordanranz
added a commit
to jessedoyle/amplify-js
that referenced
this issue
May 13, 2019
jordanranz
added a commit
that referenced
this issue
May 13, 2019
feat(aws-amplify-react-native): withOAuth Loading
|
This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
We've implemented a custom OAuth provider login in our react native application with the functionality introduced in #2665 and it's working great!
One issue we've noticed is that it's difficult to render a "loading" state when using the
withOAuthHOC as there is no ideal state field to query to determine if amplify is loading the user session.We'd like to be able to render an animation to our users so that it's clear that the application state is loading.
Describe the solution you'd like
Ideally, a
loadingprop that defaults totruecould be passed down to the wrapped component inwithOAuthhere.Describe alternatives you've considered
I haven't considered alternatives, but I'd be open to suggestions.
Additional context
N/A
I'd be happy to submit a PR to implement this functionality - it should be pretty straightforward!(PR: #3024)The text was updated successfully, but these errors were encountered: