Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Add @types/graphql dependency #2369

Closed

Conversation

manueliglesias
Copy link
Contributor

  • Add type guard for DocumentNode
  • Refactor getGraphqlOperationType

Fixes #2365
Fixes #2362

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Add type guard for DocumentNode
- Refactor `getGraphqlOperationType`

Fixes aws-amplify#2365
Fixes aws-amplify#2362
@nihakue
Copy link

nihakue commented Dec 18, 2018

Will this cause issues with consumers who aren't including 'esnext' in their tsconfig.json lib? See apollographql/graphql-subscriptions#83 AsyncIterator might not be used in the version of @types/graphql you're adding, but if it is this change could cause a new issue.

Copy link
Contributor

@haverchuck haverchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍

@samuelcastro
Copy link

samuelcastro commented Jan 4, 2019

@nihakue In fact it's generating new issues like described here: #2365

@manueliglesias Are you working on it? When should we expect the merge?

@cornr
Copy link
Contributor

cornr commented May 6, 2019

Any news on this PR?

@@ -53,6 +53,7 @@
"@aws-amplify/auth": "^1.2.13",
"@aws-amplify/cache": "^1.0.20",
"@aws-amplify/core": "^1.0.20",
"@types/graphql": "0.13.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these types to devDependencies.

@stale
Copy link

stale bot commented Jul 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 14, 2019

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.

@stale stale bot closed this Jul 14, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants