Failing builds in Typescript project using aws-amplify/api since this line was added #2365

nihakue · 2018-12-17T16:14:41Z

Describe the bug
Since the addition of the linked line, our builds have been failing with:

<truncated>/@aws-amplify/api/lib/types/index.d.ts
ERROR in <truncated>/node_modules/@aws-amplify/api/lib/types/index.d.ts(1,30):
TS7016: Could not find a declaration file for module 'graphql/language/ast'. '<truncated>/node_modules/graphql/language/ast.js' implicitly has an 'any' type.
  Try `npm install @types/graphql` if it exists or add a new declaration (.d.ts) file containing `declare module 'graphql/language/ast';`

We are using [email protected] and @aws-amplify/[email protected]. Our tsconfig.json is:

{
  "compilerOptions": {
    "baseUrl": ".",
    "outDir": "build/dist",
    "module": "esnext",
    "target": "es5",
    "lib": ["es6", "dom"],
    "sourceMap": true,
    "allowJs": true,
    "jsx": "react",
    "moduleResolution": "node",
    "rootDir": "src",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": false,
    "typeRoots": [
      "./typings/", "./node_modules/@types/"
    ]
  },
  "exclude": [
    "node_modules",
    "build",
    "scripts",
    "acceptance-tests",
    "webpack",
    "jest",
    "src/setupTests.ts"
  ]
}

I can work-around the issue with the following steps

Add @types/graphql as a dev dependency
Change typsecript lib ( tsconfig.json: compilerOptions.lib: ["esnext", "dom"])

At the moment, we aren't using graphql, so the graphql dependency is a little unfortunate.

To Reproduce
Steps to reproduce the behavior:

Create a new typescript app (we use create-react-app-ts)
Add a dependency on @aws-amplify/api
Try to build
See error

Expected behavior
When not using graphql, I shouldn't have to use graphql types.

Screenshots
N/A

Desktop (please complete the following information):

OS: Ubuntu
Browser: Any
Version Any

The text was updated successfully, but these errors were encountered:

- Add type guard for DocumentNode - Refactor `getGraphqlOperationType` Fixes aws-amplify#2365 Fixes aws-amplify#2362

hoang-innomize · 2018-12-18T02:23:20Z

I got another error related to AmplifyUI after adding graphql types.

samuelcastro · 2019-01-03T23:29:04Z

I'm facing the same problem. Is there a fixing coming @manueliglesias ?

Including @types/graphql is introducing more issues, and in fact, it's not a solution since I'm using graphql at this point.

node_modules/@types/graphql/subscription/subscribe.d.ts:36:13 - error TS2583: Cannot find name 'AsyncIterator'. Do you need to change your target library? Try changing the `lib` compiler option to es2015 or later.

36 }): Promise<AsyncIterator<ExecutionResult<TData>> | ExecutionResult<TData>>;
               ~~~~~~~~~~~~~

node_modules/@types/graphql/subscription/subscribe.d.ts:47:12 - error TS2583: Cannot find name 'AsyncIterator'. Do you need to change your target library? Try changing the `lib` compiler option to es2015 or later.

47 ): Promise<AsyncIterator<ExecutionResult<TData>> | ExecutionResult<TData>>;
              ~~~~~~~~~~~~~

node_modules/@types/graphql/subscription/subscribe.d.ts:75:12 - error TS2304: Cannot find name 'AsyncIterable'.

75 ): Promise<AsyncIterable<any> | ExecutionResult<TData>>;

revmischa · 2019-02-03T04:13:35Z

Same problem here

amwill04 · 2019-02-18T14:37:48Z

Still no resolution to this?

ffjanhoeck · 2019-02-26T07:16:44Z

Same problem

msweetland · 2019-03-02T17:00:41Z

Reporting the same issues. A short-term workaround I found is only installing the modules of Amplify that are needed and not the entire library.

EX:
yarn add @aws-amplify/auth

Most likely will not solve your issues if you're using the module that requires the graphql types.

silltho · 2019-05-03T08:20:49Z

I'm facing the same issue. Any updates to fix this?

mspoulsen · 2019-06-13T13:17:33Z

Me too :(

pbrianmackey · 2019-10-24T20:58:36Z

Upgrading to "aws-amplify": "1.1.24-beta.10", fixed it for me

Note, I tried all the workarounds in this thread. In my case nothing worked.

ColtenP · 2019-11-20T20:30:46Z

Another work around for this issue is to just declare your .d.ts file and place the following inside of the file.
declare module 'graphql/language/ast' { export type DocumentNode = any }

stale · 2019-12-20T21:11:25Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2019-12-27T21:12:03Z

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.

jono-allen · 2020-04-18T02:27:24Z

I got around this by using patch package and patching @types/react-native with

interface Storage {}
interface Cache {}
interface File {}
interface ServiceWorker {}

coleHafner · 2020-06-30T05:01:32Z

Another work around for this issue is to just declare your .d.ts file and place the following inside of the file.
declare module 'graphql/language/ast' { export type DocumentNode = any }

Just in case anyone is wondering, the best place to declare this file is to create a types.d.ts file in src/. Fixed it for me!

leopsidom · 2020-07-12T22:05:53Z

Still having this problem with "aws-amplify": "^3.0.13"

galbus · 2020-07-19T15:48:23Z

@types/graphql is deprecated, because:

graphql provides its own type definitions

Try adding graphql as a dev dependency:

yarn add -D graphql

For me, this added "graphql": "^15.3.0" into devDependencies, and removed the error I was seeing from "aws-amplify": "^3.0.20".

Ruu-i · 2020-11-29T13:41:56Z

i added declare module 'graphql/language/ast' { export type DocumentNode = any } to my d.ts file after that I got this error import { GraphQLError } from 'graphql/error/GraphQLError';. so i added declare module 'graphql/error/GraphQLError'; in to my d.ts file. again I got error errors?: GraphQLError[];. how to fix it?

nikhilavula · 2020-11-29T14:11:47Z

installing graphql solved the problem for me.

https://www.npmjs.com/package/graphql

Ruu-i · 2020-11-29T14:30:27Z

@nikhilavula i tried it. it worked. but in the browser console show this error:

ERROR TypeError: Cannot read property 'viewContainerRef' of undefined
    at AuthenticatorComponent.push.XRHW.AuthenticatorComponent.loadComponent (authenticator.factory.js:47)
    at AuthenticatorComponent.push.XRHW.AuthenticatorComponent.ngOnInit (authenticator.factory.js:31)
    at callHook (core.js:4776)
    at callHooks (core.js:4746)
    at executeInitAndCheckHooks (core.js:4698)
    at refreshView (core.js:9153)
    at refreshComponent (core.js:10291)
    at refreshChildComponents (core.js:8935)
    at refreshView (core.js:9188)
    at refreshEmbeddedViews (core.js:10245)

I'm using amplify. i just added <amplify-authenticator></amplify-authenticator> in to auth.component.html

CGarces · 2021-03-03T13:47:03Z

i added declare module 'graphql/language/ast' { export type DocumentNode = any } to my d.ts file after that I got this error import { GraphQLError } from 'graphql/error/GraphQLError';. so i added declare module 'graphql/error/GraphQLError'; in to my d.ts file. again I got error errors?: GraphQLError[];. how to fix it?

hi @Ruu-i try:

declare module 'graphql/language/ast' { export type DocumentNode = any }
declare module 'graphql/error/GraphQLError' { export type GraphQLError = any }

cadesalaberry · 2021-06-20T08:49:17Z

@CGarces I tried your solution but it led to:

Invalid module name in augmentation. Module 'graphql/error/GraphQLError' resolves to an untyped module at '/projects/my-last-project/node_modules/graphql/error/GraphQLError.js', which cannot be augmented.ts(2665)
module "graphql/error/GraphQLError"

Here is my original error:

ERROR in /projects/my-last-project/node_modules/@aws-amplify/api-graphql/lib-esm/types/index.d.ts(1,30):
1:30 Could not find a declaration file for module 'graphql/error/GraphQLError'. '/projects/my-last-project/node_modules/graphql/error/GraphQLError.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/graphql` if it exists or add a new declaration (.d.ts) file containing `declare module 'graphql/error/GraphQLError';`
  > 1 | import { GraphQLError } from 'graphql/error/GraphQLError';
      |                              ^
    2 | import { DocumentNode } from 'graphql/language/ast';
    3 | export interface GraphQLOptions {
    4 |     query: string | DocumentNode;

javadtaghia · 2021-10-03T13:28:04Z

Install npm install graphql --save-dev

github-actions · 2022-10-04T02:14:32Z

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

haverchuck assigned manueliglesias Dec 17, 2018

haverchuck added investigating This issue is being investigated API Related to REST API issues labels Dec 17, 2018

haverchuck mentioned this issue Dec 17, 2018

Cannot use namespace 'DocumentNode' as a type. #2362

Closed

manueliglesias added a commit to manueliglesias/aws-amplify that referenced this issue Dec 17, 2018

fix(api): Add @types/graphql dependency

9ea2548

- Add type guard for DocumentNode - Refactor `getGraphqlOperationType` Fixes aws-amplify#2365 Fixes aws-amplify#2362

manueliglesias mentioned this issue Dec 17, 2018

fix(api): Add @types/graphql dependency #2369

Closed

ghost added the review label Dec 17, 2018

revmischa mentioned this issue Feb 3, 2019

Typescript quickstart errors #2655

Closed

elorzafe added investigating This issue is being investigated and removed investigating This issue is being investigated labels Mar 1, 2019

jordanranz added bug Something isn't working and removed investigating This issue is being investigated labels Jun 5, 2019

willkara mentioned this issue Jul 31, 2019

Publish library as ES5/CJS and ES2015/ESM #2309

Closed

17 tasks

sammartinez removed bug Something isn't working needs-review labels Oct 28, 2019

stale bot added the pending-close-response-required label Dec 20, 2019

stale bot closed this as completed Dec 27, 2019

wlee221 mentioned this issue Oct 4, 2021

graphql Typescript build failure on strict mode #8983

Closed

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing builds in Typescript project using aws-amplify/api since this line was added #2365

Failing builds in Typescript project using aws-amplify/api since this line was added #2365

nihakue commented Dec 17, 2018 •

edited

Loading

hoang-innomize commented Dec 18, 2018

samuelcastro commented Jan 3, 2019 •

edited

Loading

revmischa commented Feb 3, 2019

amwill04 commented Feb 18, 2019

ffjanhoeck commented Feb 26, 2019

msweetland commented Mar 2, 2019 •

edited

Loading

silltho commented May 3, 2019

mspoulsen commented Jun 13, 2019

pbrianmackey commented Oct 24, 2019 •

edited

Loading

ColtenP commented Nov 20, 2019

stale bot commented Dec 20, 2019

stale bot commented Dec 27, 2019

jono-allen commented Apr 18, 2020

coleHafner commented Jun 30, 2020 •

edited

Loading

leopsidom commented Jul 12, 2020

galbus commented Jul 19, 2020 •

edited

Loading

Ruu-i commented Nov 29, 2020 •

edited

Loading

nikhilavula commented Nov 29, 2020

Ruu-i commented Nov 29, 2020 •

edited

Loading

CGarces commented Mar 3, 2021

cadesalaberry commented Jun 20, 2021

javadtaghia commented Oct 3, 2021

github-actions bot commented Oct 4, 2022

Failing builds in Typescript project using aws-amplify/api since this line was added #2365

Failing builds in Typescript project using aws-amplify/api since this line was added #2365

Comments

nihakue commented Dec 17, 2018 • edited Loading

hoang-innomize commented Dec 18, 2018

samuelcastro commented Jan 3, 2019 • edited Loading

revmischa commented Feb 3, 2019

amwill04 commented Feb 18, 2019

ffjanhoeck commented Feb 26, 2019

msweetland commented Mar 2, 2019 • edited Loading

silltho commented May 3, 2019

mspoulsen commented Jun 13, 2019

pbrianmackey commented Oct 24, 2019 • edited Loading

ColtenP commented Nov 20, 2019

stale bot commented Dec 20, 2019

stale bot commented Dec 27, 2019

jono-allen commented Apr 18, 2020

coleHafner commented Jun 30, 2020 • edited Loading

leopsidom commented Jul 12, 2020

galbus commented Jul 19, 2020 • edited Loading

Ruu-i commented Nov 29, 2020 • edited Loading

nikhilavula commented Nov 29, 2020

Ruu-i commented Nov 29, 2020 • edited Loading

CGarces commented Mar 3, 2021

cadesalaberry commented Jun 20, 2021

javadtaghia commented Oct 3, 2021

github-actions bot commented Oct 4, 2022

nihakue commented Dec 17, 2018 •

edited

Loading

samuelcastro commented Jan 3, 2019 •

edited

Loading

msweetland commented Mar 2, 2019 •

edited

Loading

pbrianmackey commented Oct 24, 2019 •

edited

Loading

coleHafner commented Jun 30, 2020 •

edited

Loading

galbus commented Jul 19, 2020 •

edited

Loading

Ruu-i commented Nov 29, 2020 •

edited

Loading

Ruu-i commented Nov 29, 2020 •

edited

Loading