Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prettier phantom dep, add dependency, bump types #755

Merged

Conversation

josefaidt
Copy link
Contributor

Description of changes

  • adds prettier as a dependency of the package that uses it
  • bumps @types/prettier to v3 to align with dep version

Issue #, if available

fixes #754

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt requested a review from a team as a code owner November 10, 2023 19:51
alharris-at
alharris-at previously approved these changes Nov 10, 2023
0618
0618 previously approved these changes Nov 10, 2023
dpilch
dpilch previously approved these changes Nov 10, 2023
@josefaidt josefaidt dismissed stale reviews from dpilch, 0618, and alharris-at via e199281 November 10, 2023 21:23
@alharris-at alharris-at merged commit 0570e9d into aws-amplify:main Nov 10, 2023
@phani-srikar phani-srikar mentioned this pull request Dec 8, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL generator imports prettier but prettier is not declared as a dependency
4 participants