Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL generator imports prettier but prettier is not declared as a dependency #754

Closed
4 tasks done
josefaidt opened this issue Nov 10, 2023 · 0 comments · Fixed by #755
Closed
4 tasks done

GraphQL generator imports prettier but prettier is not declared as a dependency #754

josefaidt opened this issue Nov 10, 2023 · 0 comments · Fixed by #755

Comments

@josefaidt
Copy link
Contributor

josefaidt commented Nov 10, 2023

Before opening, please confirm:

  • I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
  • I have searched for duplicate or closed issues.
  • I have read the guide for submitting bug reports.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?

pnpm

If applicable, what version of Node.js are you using?

20

Amplify CLI Version

latest

What operating system are you using?

mac

Amplify Codegen Command

Not applicable

Describe the bug

https://github.com/aws-amplify/amplify-codegen/blob/main/packages/graphql-generator/src/utils/GraphQLStatementsFormatter.ts#L2

see title, this breaks with certain package managers (modern yarn, maybe pnpm, npm with "linked" install strategy)

Expected behavior

prettier is declared as a dependency of the workspace package

Reproduction steps

n/a

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line


Additional information

https://rushjs.io/pages/advanced/phantom_deps/#phantom-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant