Release Amplify Codegen at major version 4 #592
Conversation
| // This is hard-coded for the schema version purpose instead of codegen version | ||
| // To avoid the failure of validation method checkCodegenSchema in JS Datastore | ||
| // The hard code is starting from amplify codegen major version 4 |
There was a problem hiding this comment.
It might be worth explaining why/when this should be revved. I.e.,
This value should be revved using semver rules when any protocol details expressed in the
/modelsfiles change.
There was a problem hiding this comment.
Maybe more to the point, this comment sounds like, "we're setting this to X because DataStore breaks otherwise." But, the value actually just identifies a protocol version, and that protocol version now deviates from package version as of package version 4.
There was a problem hiding this comment.
Yes this will be the protocol version instead. The current approach is a temporary workaround. I will mark this as a TODO to update the comments once the protocol between codegen and library is well defined after a detailed design
This reverts commit c1f9f36.
fix: use hard code codegen version in schema.js
fix lint
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.