Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: codegen downgrade to version 3 #589

Merged
merged 4 commits into from
May 9, 2023
Merged

fix: codegen downgrade to version 3 #589

merged 4 commits into from
May 9, 2023

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented May 9, 2023 •
edited
Loading

Description of changes

  • Revert the __typename change in doc generator
  • Downgrade amplify codegen to version 3 to avoid version mismatch error from JS datastore

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested a review from a team as a code owner May 9, 2023 20:08
@AaronZyLee AaronZyLee marked this pull request as draft May 9, 2023 20:11
@AaronZyLee AaronZyLee changed the title Codegen downgrade fix: codegen downgrade to version 3 May 9, 2023
@AaronZyLee AaronZyLee marked this pull request as ready for review May 9, 2023 20:45
@dpilch
Copy link
Member

dpilch commented May 9, 2023

Linking original PR for reference: #575

@AaronZyLee AaronZyLee merged commit c1f9f36 into main May 9, 2023
@AaronZyLee AaronZyLee deleted the codegen-downgrade branch May 9, 2023 21:29
AaronZyLee added a commit that referenced this pull request May 10, 2023
@AaronZyLee
Revert "fix: codegen downgrade to version 3 (#589)"
a4d2edd 
This reverts commit c1f9f36.
AaronZyLee added a commit that referenced this pull request May 10, 2023
@AaronZyLee
chore: retain the major version 4 for codegen (#591)
3885b96 
* Revert "fix: codegen downgrade to version 3 (#589)"

This reverts commit c1f9f36.

* fix: use hard code codegen version in schema.js

* fix lint
@AaronZyLee AaronZyLee mentioned this pull request May 10, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpilch dpilch dpilch approved these changes

@phani-srikar phani-srikar phani-srikar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronZyLee @dpilch @phani-srikar