World plugin #36
Merged
World plugin #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KnightArthurRen
commented
Oct 19, 2017
KnightArthurRen
commented
- Added virtual class FlatlandPlugin to be parent class for both Model Plugin and World Plugin
- Modified files to accept FlatlandPlugin
- Modified Model Plugin to inheritance from FlatlandPlugin
- Added World Plugin to support world modification
- Modified world.cpp and plugin_manager to read world plugin
- Added a example world plugin of random wall
| if (type.find("::") != std::string::npos) { | ||
| world_plugin = world_plugin_loader_->createInstance(type); | ||
| } else { | ||
| ROS_INFO_NAMED("PluginManager", "else"); |
There was a problem hiding this comment.
We probably don't need this debug bit or the below commented out parts any more
flatland_server/src/world.cpp
Outdated
|
|
||
| YamlReader world_plugin_reader = | ||
| world_reader.SubnodeOpt("plugins", YamlReader::LIST); | ||
| // world_reader.EnsureAccessedAllKeys(); |
There was a problem hiding this comment.
Does this break now with the plugins subnode?
| float RayTrace::ReportFixture(b2Fixture *fixture, const b2Vec2 &point, | ||
| const b2Vec2 &normal, float fraction) { | ||
| // only register hit in the specified layers | ||
| if (!(fixture->GetFilterData().categoryBits & 1)) { |
There was a problem hiding this comment.
Does this mean "only the first layer"? If so, that's not really the "specified" layers?
JoaoCostaIFG
pushed a commit
to JoaoCostaIFG/flatland
that referenced
this pull request
Nov 30, 2022
World plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.