[Feature] Added intensities to laser scan plugin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now laser filters returns intensities if:
a layer called "reflectance" is available.
if "reflectance" layer is available, ray traces that collides
with an element of this layer, intensity is then 255. Otherwise is 0.
it was a typo
| @@ -79,6 +79,9 @@ class Laser : public ModelPlugin, public b2RayCastCallback { | |||
| std::string frame_id_; ///< laser frame id name | |||
| bool broadcast_tf_; ///< whether to broadcast laser origin w.r.t body | |||
| uint16_t layers_bits_; ///< for setting the layers where laser will function | |||
| uint16_t reflectance_layers_bits_; ///< for setting reflectance layers. if | |||
| ///laser hits those layers, intensity will | |||
| ///be high | |||
There was a problem hiding this comment.
these two lines are the ones causing the travis-ci to fail. It wants them to not be intented. Maybe move to a block quote before the definition?
Check with
git ls-files | grep -E ".ch?$" | grep -v "thirdparty/" | xargs clang-format-3.8 --style=file -i && git diff --exit-code
josephduchesne
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now laser filters returns intensities if:
Code has been checked by clang and passes all tests.