Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to check iOS/macOS symlinks [SDK-4714] 1/2 #352

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 21, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR ensures the iOS/macOS symlinks are always in sync with the contents of the darwin directory, by adding a new CI job that:

  1. Regenerates the iOS/macOS symlinks
  2. Uses Git to check if there were any changes

If there are changes, the CI job fails and prints a message informing how to fix the problem. If there are no changes, that means the symlinks are in sync, so the job succeeds.

@Widcket Widcket requested a review from a team as a code owner November 21, 2023 15:08
@Widcket Widcket marked this pull request as draft November 21, 2023 15:08
@Widcket Widcket changed the title CI job to check iOS/macOS symlinks [SDK-4714] Add CI job to check iOS/macOS symlinks [SDK-4714] Nov 21, 2023
@Widcket Widcket changed the title Add CI job to check iOS/macOS symlinks [SDK-4714] Add CI job to check iOS/macOS symlinks [SDK-4714] 1/2 Nov 21, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/macos-support@844e03c). Click here to learn what that means.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/macos-support     #352   +/-   ##
========================================================
  Coverage                         ?   96.36%           
========================================================
  Files                            ?       98           
  Lines                            ?     1596           
  Branches                         ?      328           
========================================================
  Hits                             ?     1538           
  Misses                           ?       50           
  Partials                         ?        8           
Flag Coverage Δ
auth0_flutter 100.00% <0.00%> (?)
auth0_flutter_android 97.35% <0.00%> (?)
auth0_flutter_ios 99.85% <0.00%> (?)
auth0_flutter_platform_interface 87.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket merged commit 19afea6 into feature/macos-support Nov 23, 2023
15 checks passed
@Widcket Widcket deleted the macos-support/ci-check-symlinks branch November 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants