-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI job to check iOS/macOS symlinks [SDK-4714] 1/2 #352
Merged
Widcket
merged 3 commits into
feature/macos-support
from
macos-support/ci-check-symlinks
Nov 23, 2023
Merged
Add CI job to check iOS/macOS symlinks [SDK-4714] 1/2 #352
Widcket
merged 3 commits into
feature/macos-support
from
macos-support/ci-check-symlinks
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
changed the title
CI job to check iOS/macOS symlinks [SDK-4714]
Add CI job to check iOS/macOS symlinks [SDK-4714]
Nov 21, 2023
Widcket
changed the title
Add CI job to check iOS/macOS symlinks [SDK-4714]
Add CI job to check iOS/macOS symlinks [SDK-4714] 1/2
Nov 21, 2023
stevehobbsdev
approved these changes
Nov 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/macos-support #352 +/- ##
========================================================
Coverage ? 96.36%
========================================================
Files ? 98
Lines ? 1596
Branches ? 328
========================================================
Hits ? 1538
Misses ? 50
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR ensures the iOS/macOS symlinks are always in sync with the contents of the
darwin
directory, by adding a new CI job that:If there are changes, the CI job fails and prints a message informing how to fix the problem. If there are no changes, that means the symlinks are in sync, so the job succeeds.