Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Use symlinks with relative paths 2/2 #353

Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 21, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

The symlinks had been generated using absolute paths, which is incorrect. This PR re-generates them correctly, and modifies the generation script so that the Podspec also gets copied instead of symlinked.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (macos-support/ci-check-symlinks@ea59acb). Click here to learn what that means.

Additional details and impacted files
@@                        Coverage Diff                         @@
##             macos-support/ci-check-symlinks     #353   +/-   ##
==================================================================
  Coverage                                   ?   96.36%           
==================================================================
  Files                                      ?       98           
  Lines                                      ?     1596           
  Branches                                   ?      328           
==================================================================
  Hits                                       ?     1538           
  Misses                                     ?       50           
  Partials                                   ?        8           
Flag Coverage Δ
auth0_flutter 100.00% <0.00%> (?)
auth0_flutter_android 97.35% <0.00%> (?)
auth0_flutter_ios 99.85% <0.00%> (?)
auth0_flutter_platform_interface 87.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket changed the title Use symlinks with relative paths af: Use symlinks with relative paths Nov 21, 2023
@Widcket Widcket changed the title af: Use symlinks with relative paths af: Use symlinks with relative paths 2/2 Nov 21, 2023
@Widcket Widcket merged commit ce8c64d into macos-support/ci-check-symlinks Nov 23, 2023
18 checks passed
@Widcket Widcket deleted the macos-support/relative-symlinks branch November 23, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants