feat(fronius::schedule): Adding hysteresis logic when charging #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atbore-phx
force-pushed
the
feat/hysteresis
branch
from
59fd8b8 to
1c8d354
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.4.0 #57 +/- ##
===============================================
Coverage 98.70% 98.70%
===============================================
Files 10 10
Lines 309 310 +1
===============================================
+ Hits 305 306 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
atbore-phx
force-pushed
the
feat/hysteresis
branch
from
a172cd9 to
4ea0ea1
Compare
atbore-phx
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(init): init release v1.4.0 * feat(fronius::schedule): Net power available is derived from the reserve rather than the actual battery capacity (#55) * Feat/time reserve battery triggering (#56) * feat(fronius::schedule): The reserve battery is now charged based on time * feat(params): tuning parameters * feat(doc): adding doc * feat(ha): fixing regexp * Update DOCS.md * fix(ha): adding start and end battery reserve hours for export * feat(fronius::schedule): Adding hysteresis logic when charging (#57) * feat(fronius::schedule): Adding hysteresis logic when charging * fix(doc): adding doc * Update DOCS.md * fix(test): fix test build script dir * fix(forecast): if forecast site is unavailable disable forecast charging only (#58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47
SBAM is checking battery charge conditions every cycle, which can lead to frequent charging and discharging if the battery level is hovering around the target.
To reduce this behavior, I suggest implementing a hysteresis logic with static thresholds.
For example:
Upper threshold: 500 Wh above the target charge.
Lower threshold: 200 Wh below the target charge.
If the target charge is 3000 Wh, the thresholds would work as follows:
Charging will stop when the battery reaches 3500 Wh (target + 500 Wh).
Discharging will stop when the battery drops to 2800 Wh (target - 200 Wh).
This approach prevents the system from cycling too frequently around the target and ensures smoother operation.
These thresholds can be adjusted to suit specific needs, allowing flexibility in controlling the charge/discharge behavior.
The hysteresis logic could be applied to both reserve and general changing operations.