refactor: remove streetlight example for testing #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
previously approved these changes
May 27, 2020
jonaslagoni
reviewed
May 27, 2020
test/templateConfigValidator.test.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| const { validateTemplateConfig } = require('../lib/templateConfigValidator'); | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const streetlightYAML = fs.readFileSync(path.resolve(__dirname, './docs/streetlights.yml'), 'utf8'); | |||
| const streetlightYAML = fs.readFileSync(path.resolve(__dirname, './docs/dummy.yml'), 'utf8'); | |||
There was a problem hiding this comment.
Maybe rename to dummyYAML since streetlight is no longer a thing in the generator 🤔?
There was a problem hiding this comment.
of course, you are right, great catch, on it
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fmvilas I need your another approval, I removed streetlight named variables from tests as per @jonaslagoni suggestion |
fmvilas
approved these changes
May 27, 2020
|
🎉 This PR is included in version 0.52.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long term when we go more and more functional in templates, I believe there will be a need to separate dummy file into: dummy-ws, dummy-amqp, dummy-n files becase there might be a case in future we add support for more extensions and bindings and simply having all in one will probably not be possible (that is just an assumption)
Related issue(s)
Resolves #238