-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a dummy-like asyncapi document for testing templates functionality #238
Comments
This issue has been automatically marked as stale because it has not had recent activity 😴 |
instead of creating a dummy file, maybe we should just use https://github.com/asyncapi/tck/ as dependency to projects that need testing and use spec docs from this package? |
Yea agree, we could use that instead :) |
Hi @derberg. Meanwhile you can use the
|
@postatum yeah but you know that without proper release to npm or at least github it is super risky assuming that the directory structure of the files will never change and that maintainers know what is the purpose of the repo |
or maybe because we are also supporting fetching of spec since next week, maybe instead of publishing to npm better to have it as a part of the deployment to GitHub Pages? 🤔 |
After some research I don't think tck is what we need here. Sorry @postatum and @jstoiko for pinging you without checking the idea first. tck purpose is to check parsers coverage and it is split into multiple pieces, small parts sometimes invalid to make sure parser throws errors. This is not very usable for developing generator templates. I took streetlight, and modified it a bit to make is a dummy example and covered most of the features (they already show that html-temple misses some coverage).
We would keep it in the generator repository, and template devs would be informed it is there, and if they need "more", they should extend the example with "more". During development, they could use new generator feature, and fetch the dummy spec from generator repo Yes, I know it is not possible that some user might have a spec with 3 servers supporting 3 different protocols, but it is just a dummy document to make development easier and that is it I checked and what I created works well, nodejs-template works like a charm @jonaslagoni @fmvilas what do you think folks? |
Looks great! Should be useful 👍 When it's done I'm gonna add NATS support to the document and test it out with the NATS template 😄 |
Sounds good. This is something we'll improve over time for sure. |
🎉 This issue has been resolved in version 0.52.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reason:
At the moment, we manually test templates on a streetlight.yml example that we also modify from time to time. At some point of time, it will become a Frankenstein, and that is not the purpose of streetlight example. We should have a very dummy example that is easy to extend with all possible use cases. Later we could share it as an official test document that other templates should be tested against
Description:
The text was updated successfully, but these errors were encountered: