-
Notifications
You must be signed in to change notification settings - Fork 64
Cache the walking of the CultureInfo tree in ResourceManagerStringLocalizer #20
Conversation
|
||
using System.Runtime.CompilerServices; | ||
|
||
[assembly: InternalsVisibleTo("Microsoft.Framework.Localization.Test")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what @davidfowl thinks, but in some of the projects, we moved Internal classes to an .Internal namespace and made them public for testability instead. We don't seem to be following this on all projects, so just something to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it's just an internal method to clear a global static cache, not types.
Looks good, |
@DamianEdwards for better organization, can we introduce an interface named |
@hishamco This isn't something that should be abstracted. It's an implementation detail of this specific |
- Introduced AssemblyWrapper to enable testing - Cleaned up properties on ResourceManagerStringLocalizer - #15
Merged in 9384848 |
Implemented caching of the walk of the
CultureInfo
tree to get resource names. Includes tests.#15
@davidfowl @Eilon @muratg