Skip to content
This repository was archived by the owner on Nov 29, 2018. It is now read-only.

ResourceManagerStringLocalizer should cache GetEnumerator result #15

Closed
DamianEdwards opened this issue May 15, 2015 · 0 comments
Closed

ResourceManagerStringLocalizer should cache GetEnumerator result #15

DamianEdwards opened this issue May 15, 2015 · 0 comments
Assignees
@DamianEdwards
Labels
3 - Done enhancement
Milestone
1.0.0-beta5

Comments

@DamianEdwards
Copy link
Member

Every call to ResourceManagerStringLocalizer.GetEnumerator walks the specified CultureInfo hierarchy to build out a full set of resource names, before calling ResourceManager.GetString for every resource name. Given that resources are only loaded once by ResourceManager we should cache at least the culture walk, and probably the entire enumeration result, per culture.
@DamianEdwards DamianEdwards added this to the 1.0.0-beta5 milestone May 15, 2015
@DamianEdwards DamianEdwards self-assigned this May 19, 2015
DamianEdwards added a commit that referenced this issue May 19, 2015
@DamianEdwards
Initial attempt to cache walk of the culture tree when building resou…
e51bea8 
…rce name list:

- #15
DamianEdwards added a commit that referenced this issue May 19, 2015
@DamianEdwards
Clean up of resource string caching in ResourceManagerStringLocalizer
ceb7756 
- #15
DamianEdwards added a commit that referenced this issue May 19, 2015
@DamianEdwards
Added a unit test for CultureInfo tree walk caching
1d6b63a 
- #15
DamianEdwards added a commit that referenced this issue May 19, 2015
@DamianEdwards
Cache fixes for ResourceManagerStringLocalizer culture walk:
0072229 
- Make the cache static
- Make the cache key include the assembly name & the resource name
- #15
DamianEdwards added a commit that referenced this issue May 19, 2015
@DamianEdwards
Add test to ensure cache is unique per assembly:
9deb7cc 
- #15
@DamianEdwards DamianEdwards mentioned this issue May 19, 2015
Closed
DamianEdwards added a commit that referenced this issue May 20, 2015
@DamianEdwards
Removed Moq from tests & enabled .NET Core
31f36a8 
- Introduced AssemblyWrapper to enable testing
- Cleaned up properties on ResourceManagerStringLocalizer
- #15
DamianEdwards added a commit that referenced this issue May 20, 2015
@DamianEdwards
Slight code style changes
3f0f49a 
- #15
DamianEdwards added a commit that referenced this issue May 20, 2015
@DamianEdwards
Cache walk of the culture tree when building resource name list:
9384848 
- #15
DamianEdwards added a commit that referenced this issue May 20, 2015
@DamianEdwards
Removed Moq from tests & enabled .NET Core
4ba159a 
- Introduced AssemblyWrapper to enable testing
- Cleaned up properties on ResourceManagerStringLocalizer
- #15

Change "Strategy" to "Provider"
- #19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DamianEdwards DamianEdwards

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta5
Development

No branches or pull requests
1 participant
@DamianEdwards