main: ButtonCallbackTank: Correct the max value to 200 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CircuitCube::BuildVelocityCommand() adds 55 to the value sent to the CircuitCube. As the max value is 255, passing 255 to it results in an overflow, resulting in no Cube (Tank) movement. Limit the value to 200 so that in the end 255, the max value, is sent. In main loop() see the for() loop in TRAIN_CONTROL mode which limits the max value to 200, too. This is for non TRAIN_CONTROL mode (i.e. TRAIN_CONTROL define disabled). Signed-off-by: Dirk Behme <[email protected]>
asperka
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CircuitCube::BuildVelocityCommand() adds 55 to the value sent to the CircuitCube. As the max value is 255, passing 255 to it results in an overflow, resulting in no Cube (Tank) movement. Limit the value to 200 so that in the end 255, the max value, is sent. In main loop() see the for() loop in TRAIN_CONTROL mode which limits the max value to 200, too.
This is for non TRAIN_CONTROL mode (i.e. TRAIN_CONTROL define disabled).