-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved sb-admin-2 assets to dependencies #370
Conversation
I think I covered all the changes to the original sb-admin-2 assets. I couldn't do the media query override, but I managed to achieve the same result of a default collapsed sidebar by adding a class in the HTML markup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly CHANGELOG.md
needs updating.
Everything seems to work ok, though the NavBar has changed behaviour, here when I click to 'collapse' it instead shows the full expanded view. It should collapse fully on most screens from the default 'collapsed view'.
We decided to make this collapsed view the default and with the previous sb-admin changes I made it so the expanded NavBar view would only be seen on really high res screens (I think I set it to 3840 pixels).
Added a new responsive breakpoint, xxl: 3840px. Change the sidebar expansion breakpoint to xxl.
Thanks. I'll remember to do it the first time one day... 😣
Yeah, I couldn't figure out how to undo the media query that is declared on the However, I think I've found a way to do it by compiling the sb-admin-2 Sass files ourselves with Gulp. In doing this, I've also changed our own custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Looks good and seems to all be working well.
Merging is blocked due to a required review but the only thing I changed since the last review was resolving the merge conflict on |
Closes #369