Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sb-admin-2 dependency #369

Closed
marxide opened this issue Oct 2, 2020 · 0 comments · Fixed by #370
Closed

add sb-admin-2 dependency #369

marxide opened this issue Oct 2, 2020 · 0 comments · Fixed by #370
Assignees
@marxide
Labels
cleanup Clean up code UI User Interface
Milestone
Collaboration bet...

Comments

@marxide
Copy link
Contributor

marxide commented Oct 2, 2020 •
edited
Loading

Currently, the sb-admin-2 Bootstrap theme assets are added manually to the app static files directory. There's an official NPM package for this theme which we should add as a dependency and incorporate into our gulp tasks.

Some custom CSS rule sets have been added to sb-admin-2.css since it was originally copied, so these will need to be moved to pipeline.css. There might be custom JavaScript added to sb-admin-2.js too. A package diff should show us what needs to be moved.

https://www.npmjs.com/package/startbootstrap-sb-admin-2
@marxide marxide self-assigned this Oct 2, 2020
@marxide marxide added cleanup Clean up code UI User Interface labels Oct 2, 2020
@marxide marxide added this to the Collaboration beta release milestone Oct 2, 2020
@marxide marxide mentioned this issue Oct 2, 2020
Merged
marxide added a commit that referenced this issue Oct 3, 2020
@marxide
moved sb-admin-2 assets to dependencies
af69116 
Closes #369
@marxide marxide mentioned this issue Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marxide marxide

Labels
cleanup Clean up code UI User Interface
Projects
None yet
Milestone
Collaboration beta release
Development

Successfully merging a pull request may close this issue.

moved sb-admin-2 assets to dependencies askap-vast/vast-pipeline
1 participant
@marxide