Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactional producer #359

Merged
merged 13 commits into from
Oct 8, 2020
Merged

Transactional producer #359

merged 13 commits into from
Oct 8, 2020

Conversation

nick-zh
Copy link
Collaborator

@nick-zh nick-zh commented Mar 16, 2020

Fixes #358

rdkafka.c Outdated Show resolved Hide resolved
@nick-zh nick-zh marked this pull request as ready for review March 17, 2020 18:46
@nick-zh
Copy link
Collaborator Author

nick-zh commented Mar 23, 2020

After short discussion with @arnaud-lb, i agree that it is probably better to expose rd_kafka_error_t as Rdkafka\KafkaError to give the user even more control and transparency how to react to an error.
I will update accordingly in the coming days.

kafka_error.c Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
rdkafka.c Outdated Show resolved Hide resolved
tests/produce_consume.phpt Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
kafka_error.c Outdated Show resolved Hide resolved
@nick-zh
Copy link
Collaborator Author

nick-zh commented Jun 5, 2020

@arnaud-lb implemented the feedback and fixed / added tests, we need to merge #372 before, so tests for librdkafka:master will pass again

kafka_error_exception.c Outdated Show resolved Hide resolved
kafka_error_exception.c Outdated Show resolved Hide resolved
kafka_error_exception.c Outdated Show resolved Hide resolved
rdkafka.c Show resolved Hide resolved
@arnaud-lb arnaud-lb force-pushed the transactional-producer branch 3 times, most recently from e3bc8c2 to b2724de Compare June 26, 2020 16:40
@arnaud-lb arnaud-lb force-pushed the transactional-producer branch from b2724de to 9811f5a Compare June 26, 2020 17:56
@nick-zh nick-zh requested a review from arnaud-lb August 24, 2020 07:55
@arnaud-lb
Copy link
Owner

Thanks @nick-zh !

@nick-zh nick-zh deleted the transactional-producer branch October 8, 2020 13:24
tony2001 added a commit to tony2001/php-rdkafka that referenced this pull request Oct 14, 2020
* upstream/master:
  Transactional producer (arnaud-lb#359)
  Back to dev
  4.0.4
  Add debug to issue template (arnaud-lb#392)
  improve poll section (arnaud-lb#364)
  Build against librdkafka 1.4.4, build higher versions first
  Actually skip test
  Use a debug build in memory check
  Speed up travis builds
  fix free of topic (arnaud-lb#371)
  update settings section (arnaud-lb#374)
  remove addBroker from tests (arnaud-lb#372)
  Fix typo (arnaud-lb#346)
  Fix usage of non-existent constant (arnaud-lb#348)
  Back to dev
@arnaud-lb
Copy link
Owner

I've released version 4.1.0 with this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transactional producer
3 participants