Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Prometheus metrics #461

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

dthomson25
Copy link
Member

Closes #173 and #457

@dthomson25 dthomson25 changed the title Improve Prometheus metrics feat: Improve Prometheus metrics Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #461 into master will increase coverage by 0.28%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   85.17%   85.45%   +0.28%     
==========================================
  Files          80       83       +3     
  Lines        7539     7650     +111     
==========================================
+ Hits         6421     6537     +116     
+ Misses        804      800       -4     
+ Partials      314      313       -1     
Impacted Files Coverage Δ
controller/metrics/rollouts.go 70.45% <70.45%> (ø)
analysis/controller.go 51.89% <100.00%> (+0.61%) ⬆️
controller/metrics/analysis.go 100.00% <100.00%> (ø)
controller/metrics/client.go 100.00% <100.00%> (ø)
controller/metrics/experiments.go 100.00% <100.00%> (ø)
controller/metrics/metrics.go 100.00% <100.00%> (+20.22%) ⬆️
experiments/controller.go 70.18% <100.00%> (+0.18%) ⬆️
rollout/controller.go 72.56% <100.00%> (ø)
utils/controller/controller.go 80.15% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfd2f5...565ff40. Read the comment docs.

@dthomson25 dthomson25 linked an issue Apr 3, 2020 that may be closed by this pull request
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the creation time metrics as they don't really serve a purpose.

@dthomson25 dthomson25 merged commit 38b77a0 into argoproj:master Apr 8, 2020
@dthomson25 dthomson25 deleted the prometheus-metrics branch April 8, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics for aborted rollouts Add more prometheus metrics
2 participants