Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more prometheus metrics #173

Closed
jessesuen opened this issue Oct 1, 2019 · 2 comments · Fixed by #461
Closed

Add more prometheus metrics #173

jessesuen opened this issue Oct 1, 2019 · 2 comments · Fixed by #461
Labels
enhancement New feature or request M
Milestone
v0.8 Automated an...

Comments

@jessesuen
Copy link
Member

Need metrics for:

  • counter whenever rollout spec changes and we deploy
  • general Experiment and AnalysisRun metrics
@jessesuen
Copy link
Member Author

jessesuen commented Oct 1, 2019 •
edited
Loading

  • Consider only incrementing counters upon state changes instead of every reconciliation so that controller restarts do not spike the counters

@jessesuen jessesuen added the enhancement New feature or request label Oct 2, 2019
@malinafong malinafong added the M label Oct 21, 2019
@dthomson25
Copy link
Member

Other possible metrics include:

  • Any kubernetes client operations on resources
  • Current version
  • Detecting a usually high number of reconciliations (i.e. infinite loop in the controller)

This was referenced Apr 3, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request M
Projects
None yet
Milestone
v0.8 Automated analysis for Blue Gree...
Development

Successfully merging a pull request may close this issue.

feat: Improve Prometheus metrics dthomson25/argo-rollouts
3 participants
@dthomson25 @jessesuen @malinafong