fix: Update RS if RS's annotations need to be changed #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthomson25
changed the title
dthomson25
changed the title
dthomson25
force-pushed
the
fix-scaling-issue
branch
from
ec5399b to
3dd958e
Compare
Codecov Report
@@ Coverage Diff @@
## release-v0.7 #413 +/- ##
=============================================
Coverage 83.82% 83.82%
=============================================
Files 70 70
Lines 6604 6604
=============================================
Hits 5536 5536
Misses 778 778
Partials 290 290
Continue to review full report at Codecov.
|
jessesuen
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #412 by allowing the controller to update ReplicaSet if RS's annotations need to be changed.
Noticed that we implemented this fix in #388, but that PR is too large for a patch release.