fix: plugin did not set deployment image when using workloadRef #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
fix-workloadRef-set-image
branch
from
50fbac1 to
f203c24
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1787 +/- ##
==========================================
- Coverage 82.23% 82.18% -0.06%
==========================================
Files 116 116
Lines 16266 16284 +18
==========================================
+ Hits 13377 13383 +6
- Misses 2216 2224 +8
- Partials 673 677 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running:
kubectl argo rollouts set imageagainst a Rollout which is using the workloadRef feature, the CLI does not properly set the image on the workload (the Deployment). This change detects if the rollout is referencing a Deployment, then sets the image on the referenced Deployment.Resolves #1537
Signed-off-by: Jesse Suen [email protected]