Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo-rollouts not changing the image name for deployment referenced in workloadRef section #2162

Open
preethignanesh opened this issue Jul 26, 2022 Discussed in #2161 · 4 comments
Labels

Comments

@preethignanesh
Copy link

Discussed in #2161

Originally posted by preethignanesh July 26, 2022
I am trying the Argo rollouts for blue/green strategy. We have defined the deployments within our component spec, so while creating the rollout yaml instead of defining the pod config, I am using
workloadRef:
apiVersion: apps/v1
kind: Deployment
name: rollout-ref-deployment
to point to the existing deployment.
With this approach, rollout is creating new set of replicas specified in the rollout yaml instead of monitoring the existing deployed pods. Can't the rollout monitor the existing deployments instead of creating different replica set which in turn spins up new pods ?

Also when I try to rollout using the command - kubectl argo rollouts set image, its not changing the image tag of the existing deployment and the rollout is not progressing.
Is it possible to get the rollout command work when we have the rollout yaml pointing to the existing deployment ?

As per the discussion - https://cloud-native.slack.com/archives/C01U781DW2E/p1658770274649939
Looks like this is a bug which has been fixed - #1787
I am currently using the following plugin version -

kubectl-argo-rollouts: v1.2.1+51c874c
 BuildDate: 2022-05-13T20:40:45Z
 GitCommit: 51c874cb18e6adccf677766ac561c3dbf69a8ec1
 GitTreeState: clean
 GoVersion: go1.17.6
 Compiler: gc

And I am still facing the issue with the kubectl argo rollout set image comamnd

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@dee-github
Copy link

The issue is still happening with the below version
kubectl-argo-rollouts: v1.4.0+e40c9fe
BuildDate: 2023-01-09T20:20:38Z
GitCommit: e40c9fe
GitTreeState: clean
GoVersion: go1.19.4
Compiler: gc
Platform: linux/amd64

@lironrisk
Copy link

still happening in version v1.4.1+402c365

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants