-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle custom generators for faker #101
Merged
ardeois
merged 12 commits into
ardeois:main
from
Morphyish:feat-add-faker-custom-generators
Nov 17, 2022
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0b5d957
feat: Handle custom generators for faker
Morphyish e3fe8e7
test: Add coverage for faker custom generators
Morphyish a4b7d60
test: Update snapshots
Morphyish 626c92b
chore: Update README.md
Morphyish 52e07d4
feat: Throw error if generator library is unknown
Morphyish f525c69
chore: Add coverage for dynamicValue config
Morphyish d9dcf76
chore: Update snapshots
Morphyish 680af53
revert changes to scalar tests
Morphyish aa80127
revert changes to snapshot file
Morphyish b068493
chore: Add coverage for dynamicValue config
Morphyish 3db3df8
chore: Update snapshots
Morphyish d9f2ae9
chore: Refactor code to fix lint issues
Morphyish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`should generate custom scalars for native and custom types 1`] = ` | ||
exports[`should generate custom scalars for native and custom types using casual 1`] = ` | ||
" | ||
export const anA = (overrides?: Partial<A>): A => { | ||
return { | ||
|
@@ -20,3 +20,24 @@ export const aB = (overrides?: Partial<B>): B => { | |
}; | ||
" | ||
`; | ||
|
||
exports[`should generate custom scalars for native and custom types using faker 1`] = ` | ||
" | ||
export const anA = (overrides?: Partial<A>): A => { | ||
return { | ||
id: overrides && overrides.hasOwnProperty('id') ? overrides.id! : 83, | ||
str: overrides && overrides.hasOwnProperty('str') ? overrides.str! : 'Corrupti qui incidunt eius consequatur qui.', | ||
obj: overrides && overrides.hasOwnProperty('obj') ? overrides.obj! : aB(), | ||
anyObject: overrides && overrides.hasOwnProperty('anyObject') ? overrides.anyObject! : '[email protected]', | ||
}; | ||
}; | ||
|
||
export const aB = (overrides?: Partial<B>): B => { | ||
return { | ||
int: overrides && overrides.hasOwnProperty('int') ? overrides.int! : -93, | ||
flt: overrides && overrides.hasOwnProperty('flt') ? overrides.flt! : -24.51, | ||
bool: overrides && overrides.hasOwnProperty('bool') ? overrides.bool! : false, | ||
}; | ||
}; | ||
" | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably check if the value is
faker
and throw an error if the value is unknownThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one, but typescript told me the value couldn't be unknown. I'll add it back!