feat: Handle custom generators for faker #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardeois
reviewed
Nov 15, 2022
src/index.ts
Outdated
| return getCasualCustomScalarValue(customScalar, opts); | ||
| } | ||
|
|
||
| return getFakerCustomScalarValue(customScalar, opts); |
There was a problem hiding this comment.
You should probably check if the value is faker and throw an error if the value is unknown
There was a problem hiding this comment.
I had one, but typescript told me the value couldn't be unknown. I'll add it back!
|
@Morphyish could you fix the lint so I can merge please |
|
@ardeois Done, linter should be good now. |
ardeois
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow users to add custom generators when using the faker library.
The syntax is similar to the current generators for casual.
Related open issue: #97