-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coded sample logic #1516 #1535
Conversation
8a9f213
to
1aa74b5
Compare
TODO: test report workflow annotations
7791746
to
a5e8865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I added handling for that, but to reproduce the issue I had to create a physical thing without a name, and that causes issues all over the workflows, e.g.: resource.js:20 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'results')
at eval (resource.js:20:44)
at async Promise.all (index 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #1516
TODO: check report workflow once I can load it