Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded sample logic #1516 #1535

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Remove hard-coded sample logic #1516 #1535

merged 8 commits into from
Jan 17, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jan 12, 2024

Closes #1516

TODO: check report workflow once I can load it

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, but I'm getting this error when trying to load the final step of the sample taking workflow: image

_label in the case of my resource instance appears to be undefined:
image

@jacobtylerwalls
Copy link
Member Author

Cool, I added handling for that, but to reproduce the issue I had to create a physical thing without a name, and that causes issues all over the workflows, e.g.:

resource.js:20 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'results')
    at eval (resource.js:20:44)
    at async Promise.all (index 0)

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit 08372b6 into localization Jan 17, 2024
1 check passed
@chiatt chiatt deleted the 1516-sample-logic branch January 17, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Remove hard-coded "sample" and "analysis area" logic
2 participants