Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Remove hard-coded "sample" and "analysis area" logic #1516

Closed
jacobtylerwalls opened this issue Jan 4, 2024 · 0 comments · Fixed by #1535
Closed

[i18n] Remove hard-coded "sample" and "analysis area" logic #1516

jacobtylerwalls opened this issue Jan 4, 2024 · 0 comments · Fixed by #1535
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

Referenced on localization branch with TODO(i18n) samples
This was referenced Jan 4, 2024
Merged
Closed
@jacobtylerwalls jacobtylerwalls self-assigned this Jan 4, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In progress in afs-pipeline Jan 4, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 🔖 Ready in afs-pipeline Jan 5, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Jan 12, 2024
jacobtylerwalls added a commit to jacobtylerwalls/arches-for-science-prj that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove hard-coded sample name on backend archesproject#1516
8c4493b
jacobtylerwalls added a commit to jacobtylerwalls/arches-for-science-prj that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove hard-coded sample name on frontend archesproject#1516
0933d20
jacobtylerwalls added a commit to jacobtylerwalls/arches-for-science-prj that referenced this issue Jan 12, 2024
@jacobtylerwalls
Standardize sampleOf and analysisAreaOf archesproject#1516
0fa9510
jacobtylerwalls added a commit to jacobtylerwalls/arches-for-science-prj that referenced this issue Jan 12, 2024
@jacobtylerwalls
Localize two more strings archesproject#1516
112be9a
jacobtylerwalls added a commit to jacobtylerwalls/arches-for-science-prj that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove more hardcoded sample logic archesproject#1516
a7f1782 
TODO: test report workflow annotations
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove hard-coded sample name on backend #1516
ccd4195
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove hard-coded sample name on frontend #1516
4f83924
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Standardize sampleOf and analysisAreaOf #1516
e695625
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Localize two more strings #1516
6620c5c
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove more hardcoded sample logic #1516
9551937 
TODO: test report workflow annotations
@jacobtylerwalls jacobtylerwalls mentioned this issue Jan 12, 2024
Merged
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Jan 12, 2024
jacobtylerwalls added a commit that referenced this issue Jan 12, 2024
@jacobtylerwalls
Remove hardcoded sample substrings #1516
7791746
@jacobtylerwalls jacobtylerwalls linked a pull request Jan 12, 2024 that will close this issue
Remove hard-coded sample logic #1516 #1535
Merged
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Remove hard-coded sample name on backend #1516
06e3f44
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Remove hard-coded sample name on frontend #1516
ab628ad
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Standardize sampleOf and analysisAreaOf #1516
9b81e96
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Localize two more strings #1516
c7fb668
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Remove more hardcoded sample logic #1516
78a7339 
TODO: test report workflow annotations
jacobtylerwalls added a commit that referenced this issue Jan 13, 2024
@jacobtylerwalls
Remove hardcoded sample substrings #1516
a5e8865
jacobtylerwalls added a commit that referenced this issue Jan 15, 2024
@jacobtylerwalls
Add handling for no label re #1516
4046d16
chiatt added a commit that referenced this issue Jan 17, 2024
@chiatt
Merge pull request #1535 from archesproject/1516-sample-logic
08372b6 
Remove hard-coded sample logic #1516
@chiatt chiatt closed this as completed Jan 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Jan 17, 2024
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hard-coded sample name on backend #1516
ac6902f
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hard-coded sample name on frontend #1516
24c6226
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Standardize sampleOf and analysisAreaOf #1516
1680fa9
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Localize two more strings #1516
4e107e9
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove more hardcoded sample logic #1516
6be7f28 
TODO: test report workflow annotations
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hardcoded sample substrings #1516
c67f844
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Add handling for no label re #1516
632809a
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hard-coded sample name on backend #1516
053e332
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hard-coded sample name on frontend #1516
4fe4143
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Standardize sampleOf and analysisAreaOf #1516
86484f8
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Localize two more strings #1516
696415b
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove more hardcoded sample logic #1516
4ffbcee 
TODO: test report workflow annotations
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Remove hardcoded sample substrings #1516
5880a50
jacobtylerwalls added a commit that referenced this issue Jan 17, 2024
@jacobtylerwalls
Add handling for no label re #1516
644a4fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hard-coded sample logic #1516 archesproject/arches-for-science
2 participants
@chiatt @jacobtylerwalls