Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist headers in search item description even if there is no data, #40 #41

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -371,13 +371,12 @@ function addDrawControls() {

function addOverlayToMap(overlay: MapLayer) {
overlay.layerdefinitions.forEach((layerDefinition: LayerDefinition) => {

map.value!.on('mouseenter', layerDefinition.id, () => {
map.value!.getCanvas().style.cursor = 'pointer';
map.value!.on("mouseenter", layerDefinition.id, () => {
map.value!.getCanvas().style.cursor = "pointer";
});

map.value!.on('mouseleave', layerDefinition.id, () => {
map.value!.getCanvas().style.cursor = '';
map.value!.on("mouseleave", layerDefinition.id, () => {
map.value!.getCanvas().style.cursor = "";
});

if (!map.value!.getSource(layerDefinition.source!)) {
Expand Down
80 changes: 52 additions & 28 deletions afrc/src/afrc/Search/components/SearchItemDetails.vue
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,24 @@ function clearResult() {
</div>
</div>
<div class="description">
<template
v-if="displaydescription && displaydescription != 'Undefined'"
>
<!-- eslint-disable-next-line vue/no-v-html -->
<div v-html="displaydescription"></div>
</template>
<div v-else>No description provided</div>
<div class="value-header">Description</div>
<div class="resource-details-value">
<template
v-if="
displaydescription && displaydescription != 'Undefined'
"
>
<!-- eslint-disable-next-line vue/no-v-html -->
<div v-html="displaydescription"></div>
</template>
<div v-else>No description provided</div>
</div>
</div>
<div
class="value-header"
style="padding: 0 10px"
>
Images
</div>
<div
v-if="images.length"
Expand Down Expand Up @@ -140,6 +151,13 @@ function clearResult() {
</template>
</Carousel>
</div>
<div
v-else
class="resource-details-value"
style="padding: 0 13px"
>
<div>No images available</div>
</div>
<div
class="resource-details"
style="color: grey"
Expand All @@ -166,30 +184,36 @@ function clearResult() {
>
</div>
</div>
<div
v-if="acquisitions"
class="resource-details"
>
<div class="resource-details">
<div class="value-header">Acquisition Information</div>
<div v-if="acquisitions">
<div
v-for="(acquisition, index) in acquisitions"
:key="index"
>
<div class="value-entry">
Acquired by:<span class="resource-details-value">{{
acquisition.person
}}</span>
</div>
<div class="value-entry">
Acquired on:<span class="resource-details-value">{{
acquisition.date
}}</span>
</div>
<div class="value-entry">
Acquisition Details:<span
class="resource-details-value"
>{{ acquisition.details }}</span
>
</div>
</div>
</div>
<div
v-for="(acquisition, index) in acquisitions"
:key="index"
v-else
class="resource-details-value"
>
<div class="value-entry">
Acquired by:<span class="resource-details-value">{{
acquisition.person
}}</span>
</div>
<div class="value-entry">
Acquired on:<span class="resource-details-value">{{
acquisition.date
}}</span>
</div>
<div class="value-entry">
Acquisition Details:<span class="resource-details-value">{{
acquisition.details
}}</span>
</div>
No acquisition information available
</div>
</div>
<div class="resource-details">
Expand Down
Loading