Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist headers in search item description even if there is no data, #40 #41

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Mar 5, 2025

Previously the result details panel headers would be missing if a resource did not have information to populate those sections.
image

This PR persists those headers and indicates that no data is available.
image

@chiatt chiatt requested a review from apeters March 5, 2025 00:39
Copy link
Member

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@apeters apeters merged commit 23b67bd into main Mar 6, 2025
2 of 6 checks passed
@apeters apeters deleted the cnh/search-item-details-layout-fixes branch March 6, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants