Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate official aragon apps to Buidler set up #1084

Closed
wants to merge 28 commits into from

Conversation

eternauta1337
Copy link

@eternauta1337 eternauta1337 commented Feb 24, 2020

== Migration cheatsheet ==

  • Grab a boilerplate copy from one of the already ported apps (buidler-apps/voting), and place it in buidler-apps/new_app/. The first boilerplate was obtained from aragon-buidler-boilerplate using create-aragon-app.
  • Make sure node_modules is not copied from the previous step. If present, delete it.
  • Merge original package.json and new package.json.
  • Npm i
  • Copy original_app/arapp.json's roles and path to new_app/arapp.json.
  • Copy original_app/manifest.json entirely to new_app/manifest.json.
  • Delete new_app/app/ and replace it with original_app/app/.
  • Replace new_app/app/package.json scripts with those from one of the already ported apps (buidler-apps/voting/app/package.json).
  • Replace new_app/contracts/ with original_app/contracts/.
  • Replace new_app/contracts/test/TestImports.sol with the one from one of the already ported apps (buidler-apps/voting/contracts/test/TestImports.sol).
  • Comment out new_app/buidler.config.js aragon.hooks.
  • Run npm start until no dependency errors exist.
    • Dependencies might be missing. Go ahead and install them in new_app/. Copy dependencies from the original_app/package.json and paste them in new_app/package.json in the appropriate place.
    • As soon as you get to a runtime error, continue to the next step.
  • Uncomment new_app/buidler.config.js aragon.hooks, and properly implement new_app/scripts/buidler-hooks.js according to the specific deployment setup of the app. Hint: looking at how things are set up in original_app/test/* makes it pretty straight forward.
  • Test UI.
  • Delete contents of new_app/test/, and replace with original_app/test/.
  • Run npm test, porting them from Web3 0.20.x to 1.0.x.
    • Fix errors until all tests pass.
  • Push!
  • Update this PR description with the issue/fix number.

@eternauta1337
Copy link
Author

Closing this PR in favor of #1092, which directly modifies the original app folders.

@sohkai sohkai deleted the buidler-migration branch March 7, 2020 22:26
@sohkai sohkai mentioned this pull request Apr 4, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants