Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to buidler-aragon #1111

Closed
6 of 10 tasks
sohkai opened this issue Apr 4, 2020 · 0 comments · Fixed by #1131
Closed
6 of 10 tasks

Migrate to buidler-aragon #1111

sohkai opened this issue Apr 4, 2020 · 0 comments · Fixed by #1131
Assignees

Comments

@sohkai
Copy link
Contributor

sohkai commented Apr 4, 2020


Tests:

  • WIP Fix Migrate vault to Buidler aragon-cli#1509 (vault)
    • Failing test: set up the default vault correctly to recover ETH from the kernel - ALSO FAILS ON MASTER
  • WIP Fix Migrate agent to Buidler aragon-cli#1484 (agent)
    • Also runs vault tests, and as stated above, one of them fails - ALSO FAILS ON MASTER
  • WIP Fix Migrate finance to Buidler aragon-cli#1483 (finance)
    • Three tests failing:
      • "can recover ETH using AragonApp#transferToVault" - ALSO FAILS ON MASTER
      • "fails when too many period transitions are needed"
        • fails, unless gas is set to 3e6 (ten times as much!)
        • passes in master with 3e5 gas, even if ganache-cli.sh is modified to use istanbul
        • Buidler currently has an issue where the fork cannot be modified (reported, fix soon)
        • Also fails when running npx buidler test --network localhost with a running ganache-cli instance with any fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants