Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard for Kubernetes pods #66

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

jeffkreeftmeijer
Copy link
Member

Much like #64, but for pods. Part of appsignal/appsignal-kubernetes#2.

@matsimitsu
Copy link
Member

Any idea how many additional metrics this would generate, asking for a friend..

@unflxw
Copy link
Contributor

unflxw commented Apr 26, 2024

As mentioned in #64, it would be nice to have human readable descriptions.

@jeffkreeftmeijer
Copy link
Member Author

Any idea how many additional metrics this would generate, asking for a friend..

Hm, tell your friend we're not sure as of right now. In theory, a Kubernetes cluster could have a lot of pods, much like a non-Kubernetes setup could have a lot of hosts. Would not knowing this be a blocker to push this out?

@backlog-helper

This comment has been minimized.

@matsimitsu
Copy link
Member

matsimitsu commented Apr 29, 2024

Hm, tell your friend we're not sure as of right now. In theory, a Kubernetes cluster could have a lot of pods, much like a non-Kubernetes setup could have a lot of hosts. Would not knowing this be a blocker to push this out?

Not nessicarily, it's mainly that we know lots of short-lived hosts(pods) could be an issue in terms of fetching the metrics. It's a weak point in the way the current custom metrics system works, that if you have one metric name (e.g. pod_load_avg and it has a huge number of individual tags (pod-xxx) that it could time out.

Also in the ingestion side we have a 4-megabyte document limit for MongoDB, and we know that customers with a ton of short-lived unique hosts hit that limit regularly. (The way it currently works is that the entire 4+ megabytes will be discarded, creating a gap in all the charts).

This doesn't block releasing this dashboard, but it's good to know the implications :)

@backlog-helper

This comment has been minimized.

2 similar comments
@backlog-helper

This comment has been minimized.

@backlog-helper
Copy link

backlog-helper bot commented May 2, 2024


This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

@jeffkreeftmeijer
Copy link
Member Author

@matsimitsu thanks for the explanation here. Let's keep an eye on this.

I'm merging this now. Could you ping me when this is deployed? :)

@jeffkreeftmeijer jeffkreeftmeijer merged commit 27958a7 into main May 2, 2024
1 check passed
@jeffkreeftmeijer jeffkreeftmeijer deleted the kubernetes-pods branch May 2, 2024 13:35
@matsimitsu
Copy link
Member

@jeffkreeftmeijer it's been deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants