Add pod metrics #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkreeftmeijer
requested review from
thijsc,
tombruijn,
luismiramirez and
unflxw
tombruijn
approved these changes
Apr 26, 2024
thijsc
approved these changes
Apr 26, 2024
This comment has been minimized.
This comment has been minimized.
luismiramirez
approved these changes
Apr 29, 2024
This comment has been minimized.
This comment has been minimized.
unflxw
approved these changes
Apr 30, 2024
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This is a message from the daily scheduled checks. |
Instead of unwrapping the value in kube_response["pods"], use a match to verify the result is actually a vec before looping over it to extract metrics.
jeffkreeftmeijer
force-pushed
the
pods-no-switch
branch
from
daeb0c9 to
d07186c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds pod metrics next to the node metrics already reported. The pod-specific metrics will have a dashboard separate from the host metrics one on AppSignal.com.
Merging this will require an updated container to be pushed.