feat(rover): config api-key -> config profile auth #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
ashleygwilliams,
JakeDawkins and
StephenBarlow
as code owners
EverlastingBugstopper
force-pushed
the
avery/move-api
branch
3 times, most recently
from
0052582 to
2c032a2
Compare
JakeDawkins
approved these changes
Dec 9, 2020
lrlna
approved these changes
Dec 9, 2020
EverlastingBugstopper
force-pushed
the
avery/move-api
branch
from
2c032a2 to
31482d2
Compare
|
good catch @lrlna - i updated the help text on the profile page as well :) |
|
sweet, thanks @EverlastingBugstopper! Go ahead and merge when you have time today o/ |
EverlastingBugstopper
force-pushed
the
avery/move-api
branch
from
31482d2 to
1a8981e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107 by moving the
rover config api-keycommand to be executed by runningrover config profile authinstead.This is more consistent with the
rover [NOUN] [VERB]pattern seen elsewhere within the CLI, but nests further under another noun. This new authentication structure isrover [NOUN] [NOUN] [VERB], which matches the other profile-related commands likerover config profile listandrover config profile show.