Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: move api-key under profile subcommand #107

Closed
EverlastingBugstopper opened this issue Dec 2, 2020 · 0 comments · Fixed by #114
Closed

RFC: move api-key under profile subcommand #107

EverlastingBugstopper opened this issue Dec 2, 2020 · 0 comments · Fixed by #114
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs decision 🤝
Milestone
🐣 0.0.1

Comments

@EverlastingBugstopper
Copy link
Contributor

The api-key subcommand allows you to configure a Rover profile. However, they are sibling subcommands at the moment, when we probably want to have the functionality live under profile.

I'm proposing we change authentication usage from the current world of rover config api-key to rover config profile auth. The thought is that this will communicate more clearly to end users that their API key is linked to a profile, and profiles can be managed with the other config profile subcommands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages needs decision 🤝
Projects
None yet
Milestone
🐣 0.0.1
Development

Successfully merging a pull request may close this issue.

feat(rover): config api-key -> config profile auth apollographql/rover
1 participant
@EverlastingBugstopper