Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover supergraph compose command fails to prompt for license #1455

Open
DoumanAsh opened this issue Dec 14, 2022 · 3 comments · Fixed by #1486
Open

rover supergraph compose command fails to prompt for license #1455

DoumanAsh opened this issue Dec 14, 2022 · 3 comments · Fixed by #1486
Labels
bug 🐞 triage issues and PRs that need to be triaged

Comments

@DoumanAsh
Copy link
Contributor

Version:

13:23 $ rover --version
Rover 0.9.1

OS: Windows 10

When I try to execute command it fails with:

By installing this plugin, you accept the terms and conditions outlined by this license.
More information on the ELv2 license can be found here: https://go.apollo.dev/elv2.
Do you accept the terms and conditions of the ELv2 license? [y/N]
error: This command requires that you accept the terms of the ELv2 license.

I have no idea how to accept license and why it doesn't even prompt me to enter y or n

@DoumanAsh DoumanAsh added bug 🐞 triage issues and PRs that need to be triaged labels Dec 14, 2022
@DoumanAsh
Copy link
Contributor Author

DoumanAsh commented Dec 14, 2022

Ok after checking source code I found that flag --elv2-license ignores any value that I attempted without erroring out.
It seems it needs to document how to provide value to this flag (honestly why would you not make it simple boolean flag is beyond me)

@EverlastingBugstopper EverlastingBugstopper changed the title rover supergraph compose command fails with license bullshit rover supergraph compose command fails to prompt for license Dec 14, 2022
@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Dec 14, 2022

@DoumanAsh - I understand this was frustrating for you. I would like to refer you to our code of conduct, specifically the following section:

A Welcoming and Safe Environment

We hope to create an environment in which diverse individuals can collaborate and interact in a positive and affirming way. Examples of behavior that contributes to creating this sort of environment include:

  • Using welcoming and inclusive language
  • Being respectful of differing viewpoints and experiences
  • Gracefully accepting constructive criticism
  • Focusing on what is best for the overall community
  • Showing empathy towards other community members

rover supergraph compose command fails with license bullshit is not an appropriate title for an issue opened on this repository, and is not in line with the guidelines set out by our code of conduct. Additionally honestly why would you not make it simple boolean flag is beyond me is not constructive and it does not provide any extra information on the issue you encountered. There are real people that work on this project that read your comments, and it impacts them. Sometimes program behavior does not align with what you expect. In these scenarios, it is appropriate to open an issue. It is not appropriate to channel that frustration towards the maintainers of this project. We want to provide a good experience and are always happy to help with issues you may encounter. However, using language like this is not appropriate, will not be tolerated, and is not likely to result in what you want. I do not personally want to work on fixing something that some random person on the internet decided was worth verbally harassing me about.

In light of this, I have edited the issue title to more accurately and calmly express what you encountered here. In the future I would ask that you write issues with respect for the maintainers, the project, and the community, or you will no longer have the privilege of interacting with this repository.


Now. With that out of the way, I'm not entirely sure why the y/N prompt is not working on Windows. It's something we should look into. Additionally, the error message you encountered should tell you what the appropriate value to pass to that argument is.

To take action on this ticket, an implementor must

  • Add a RoverErrorSuggestion that suggests passing --elv2-license accept to accept the license when this error is encountered.
  • Make sure that this error is not encountered for folks on Windows that are attached to a terminal. This hard error should only occur in CI systems or when a TTY is not attached and the user is unable to input text.
  • Specify that "accept" is the only valid value for this flag in the --help text

EverlastingBugstopper added a commit that referenced this issue Jan 24, 2023
# [0.11.0] - 2023-01-24

## 🚀 Features

- **Manage contract configuration - @sachindshinde, #1475 fixes #1421**
 
Rover now includes two commands for creating, modifying, and reading
contracts: `rover contract publish` and `rover contract describe`.
Further documentation can be found
[here](https://www.apollographql.com/docs/rover/commands/contracts).

- **Easier file output with new `--output` argument - @gocamille, #1413
fixes #1212**

The `--output` argument has long been used to configure the format of
Rover's output. i.e. `--output json` configures Rover to print its
output as a JSON object. This argument has been _renamed_ to `--format`
while maintaining backwards compatibility. `--format json` should be
used to configure the format of Rover's output, and the `--output`
argument allows you to specify a file to print the output to. Adding
`--output schema.graphql` to a `rover subgraph fetch` command will
output your schema to a file. `--output data.json --format json` will
output the command data to `data.json`. `--output json` will still work
by itself but will now print a warning, and `--output [json|plain]` does
not work with `--format [json|plain]`. Further documentation can be
found
[here](https://www.apollographql.com/docs/rover/conventions#output-to-a-file).

- **Adds `--router-config` to `rover dev` - @EverlastingBugstopper,
#1446 fixes #1373, #1345, and #1468**

The new `--router-config` argument for `rover dev` allows you to pass a
[router configuration file]() on startup that can configure settings
such as header propagaion and CORS policies. Further documentation can
be found
[here](https://www.apollographql.com/docs/rover/commands/dev/#advanced-configuration).

- **Auto-update router versions in `rover dev` - @EverlastingBugstopper,
#1432**

`rover dev` will automatically use the version of the router specified
in [this plugin
file](https://github.com/apollographql/rover/blob/main/latest_plugin_versions.json)
instead of a hard coded version.

## 🛠 Maintenance

- **Better error and help text for ELv2 license argument - @DoumanAsh,
#1456 fixes #1455**

The help text for the `--elv2-license` argument now includes the
expected value for the argument, in addition to the error message
returned when the argument is needed but not passed.

- **Updates the Ariadne template URL - @patrick91, #1439**

- **Updates `./examples/supergraph-demo` to `@apollo/server` v4, and
removes `./examples/dev` - @EverlastingBugsttopper, #1442 fixes #1440
and #1441**

- **Updates dependencies - @EverlastingBugstopper, #1481, #1450**

  `apollo-parser` 0.3 -> 0.4
  `base64` 0.13 -> 0.21
  `git2` 0.15 -> 0.16
  `graphql_client` 0.11.0 -> 0.12
  `serial_test` 0.9 -> 1.0
  `os_info` 3.4 -> 3.5
  `os_type` 2.4 -> 2.6
  `termcolor` 1.1 -> 1.2
  `tokio` 1.21 -> 1.24

## 📚 Documentation

- **Fixes a link to schema check example - @MayCXC, #1431**
@SalemWafi
Copy link

SalemWafi commented Dec 9, 2024

Continuation on @DoumanAsh's comment solution.

The flag and its value should be --elv2-license "accept" 🤦‍♂️

p.s.
Thanks for the PR this description helped when it errored out for me when I used --elv2-license true:

Err(anyhow!("Allowed values: 'accept'"))

p.p.s
I'm using the latest rover version 0.26.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 triage issues and PRs that need to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants