Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Boolean instead of string for accepting the License agreement #2293

Closed
SalemWafi opened this issue Dec 9, 2024 · 1 comment
Closed
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged

Comments

@SalemWafi
Copy link

SalemWafi commented Dec 9, 2024

Description

Change the flag value --elv2-license "accept" to accept a boolean value instead of that; It would be like this --elv2-license true
This will make it more obvious for most end-users.

When that is implemented, these docs need to be updated with this change:


Related issue:
#1455

Related Code:
https://github.com/apollographql/rover/blob/6699487c2cae5493bb4ebd93a715a3d53b60ef0f/src/options/license.rs#L77C1-L83C2

@SalemWafi SalemWafi added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Dec 9, 2024
@abernix
Copy link
Member

abernix commented Dec 9, 2024

Thanks for opening this issue. We chose accept initially because it satisfactory answers the question of "do you accept the license agreement of the ELv2 license". The answer true, doesn't satisfactorily answer that from a legal language perspective. Apologies, but this isn't something that is ever likely to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants