Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always accept compressed subgraph responses #2450

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jan 20, 2023

Subgraph response decompression was only supported when subgraph request compression was configured, this is now always active

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

@Geal Geal requested a review from StephenBarlow as a code owner January 20, 2023 15:16
@github-actions

This comment has been minimized.

@Geal Geal requested review from a team, SimonSapin and o0Ignition0o and removed request for a team January 20, 2023 15:18
@SimonSapin
Copy link
Contributor

Clippy errors on const ACCEPTED_ENCODINGS: HeaderValue with “a const item should never be interior mutable”. I suspect the mutability in question is the atomic refcounter inside Bytes inside, but it’s never used for a value constructed with from_static:

https://docs.rs/bytes/1.3.0/src/bytes/bytes.rs.html#162-169
https://docs.rs/bytes/1.3.0/src/bytes/bytes.rs.html#872-890

@SimonSapin
Copy link
Contributor

It’s an AtomicPtr but same reasoning: rust-lang/rust-clippy#5812

I think #[allow] is the right thing here.

@Geal
Copy link
Contributor Author

Geal commented Jan 23, 2023

yes, the allow would make sense

@Geal Geal enabled auto-merge (squash) January 24, 2023 08:24
@Geal Geal merged commit 75ffc95 into dev Jan 24, 2023
@Geal Geal deleted the geal/always-accept-compression branch January 24, 2023 08:41
@abernix abernix mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accept compressed subgraph responses by default
3 participants