Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept compressed subgraph responses by default #2415

Closed
Geal opened this issue Jan 17, 2023 · 0 comments · Fixed by #2450
Closed

accept compressed subgraph responses by default #2415

Geal opened this issue Jan 17, 2023 · 0 comments · Fixed by #2450
Assignees
@Geal

Comments

@Geal
Copy link
Contributor

Geal commented Jan 17, 2023

ref: https://github.com/apollographql/router/pull/2353/files#r1072184632

apparently the router will only set the accept header for subgtraph response compression if it sends compressed requests to subgraph. I think that accept header should always be set. Any opinions?
@Geal Geal mentioned this issue Jan 17, 2023
Merged
@Geal Geal self-assigned this Jan 20, 2023
@Geal Geal mentioned this issue Jan 20, 2023
Merged
6 tasks
Geal pushed a commit that referenced this issue Jan 24, 2023
always accept compressed subgraph responses (#2450)
75ffc95 
- Fix #2415

Subgraph response decompression was only supported when subgraph request
compression was configured, this is now always active
@abernix abernix mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

always accept compressed subgraph responses apollographql/router
1 participant
@Geal