Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions for the bundledPrinter #63

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Conversation

kamilkisiela
Copy link
Contributor

There's no any right now and it breaks typescript compilation in some cases.

@jnwng We need it in apollo-angular

@jnwng
Copy link
Contributor

jnwng commented Mar 20, 2017

got it — we have these type definitions for the external APIs for printer and parser but not for the bundledVersions (which are used to get around the deprecation warnings)

thanks for the PR!

@jnwng jnwng merged commit 89059fa into 1.3.0 Mar 20, 2017
@jnwng jnwng deleted the declare-print branch March 20, 2017 16:04
@Urigo
Copy link

Urigo commented Mar 20, 2017

awesome!
@jnwng is there a chance you could release 1.3.2 soon?
Sorry for the urgency, I just want to merge a big PR that depends on that..

@jnwng
Copy link
Contributor

jnwng commented Mar 20, 2017 via email

@stubailo
Copy link
Contributor

@jnwng I want to add you on npm, just tell me your username!

@helfer
Copy link
Contributor

helfer commented Mar 21, 2017

@jnwng published!

I've also added you as an owner of graphql-tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants