Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the declaration of graphql-tag/bundledPrinter #1462

Merged
merged 3 commits into from
Mar 28, 2017

Conversation

kamilkisiela
Copy link
Contributor

thanks to apollographql/graphql-tag#63 graphql-tag@^1.3.2 contains declaration of print function.

@kamilkisiela
Copy link
Contributor Author

And why we have this in apollo-client and not in graphql-tag?

@helfer
Copy link
Contributor

helfer commented Mar 21, 2017

@kamilkisiela I have no idea why that is in apollo-client and not in graphql-tag. Can you please remove it as well (if necessary with an extra PR to graphql-tag)?

@kamilkisiela
Copy link
Contributor Author

@helfer sure

@helfer
Copy link
Contributor

helfer commented Mar 28, 2017

Thanks @kamilkisiela!

@helfer helfer merged commit 15a15f5 into master Mar 28, 2017
@helfer helfer deleted the bundled-printer-dts branch March 28, 2017 00:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants