Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using Object.assign to attach extra properties to gql. #380

Merged
merged 1 commit into from
Mar 18, 2021
+16 −3
Merged

Avoid using Object.assign to attach extra properties to gql. #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,24 @@ export function disableExperimentalFragmentVariables() {
experimentalFragmentVariables = false;
}

export default Object.assign(gql, {
const extras = {
gql,
default: gql,
resetCaches,
disableFragmentWarnings,
enableExperimentalFragmentVariables,
disableExperimentalFragmentVariables,
});
};

export namespace gql {
export const {
gql,
resetCaches,
disableFragmentWarnings,
enableExperimentalFragmentVariables,
disableExperimentalFragmentVariables,
} = extras;
}

gql.default = gql;
Comment on lines +161 to +171
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, since default is a reserved word, there doesn't seem to be any way to export it from the namespace gql block above.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on microsoft/TypeScript#24164


export default gql;