Avoid using Object.assign to attach extra properties to gql. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
avoid-Object.assign
branch
from
25e0cc6 to
9a09ce6
Compare
benjamn
commented
Mar 18, 2021
Comment on lines
+161
to
+171
| export namespace gql { | ||
| export const { | ||
| gql, | ||
| resetCaches, | ||
| disableFragmentWarnings, | ||
| enableExperimentalFragmentVariables, | ||
| disableExperimentalFragmentVariables, | ||
| } = extras; | ||
| } | ||
|
|
||
| gql.default = gql; |
There was a problem hiding this comment.
Unfortunately, since default is a reserved word, there doesn't seem to be any way to export it from the namespace gql block above.
There was a problem hiding this comment.
Waiting on microsoft/TypeScript#24164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #373.