fix: extensions argument ignored by ForbiddenError and AuthorizationError #5309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised here, currently only
UserInputError
supports passing arbitrary data in the extensions argument but the docs imply all ApolloError's support this.This MR allows passing the extra extensions argument to the underlying constructor.
I did also attempt to apply this to all the Error classes (except persisted ones) but ran into some typescript errors caused by invalid
sendErrorResponse
calls inapollo-server-core/src/requestPipeline.ts
so I just applied the changes toForbiddenError
andAuthorizationError
.Perhaps this inconsistency means the docs should also be updated to clarify which error constructors support extensions too but thought I'd get the ball rolling with this fix MR