fix: extensions argument not being passed down by Forbidden and Autho…

…rization errors (#5309)

Co-authored-by: Jon Wyatt <[email protected]>

packages/apollo-server-errors/src/__tests__/ApolloError.test.ts

@@ -1,4 +1,4 @@
-import { ApolloError } from '..';
+import { ApolloError, ForbiddenError, AuthenticationError } from '..';
 
 describe('ApolloError', () => {
   it("doesn't overwrite extensions when provided in the constructor", () => {
@@ -48,3 +48,29 @@ describe('ApolloError', () => {
     ).toThrow(/Pass extensions directly/);
   });
 });
+
+describe("ForbiddenError", () => {
+  it("supports abritrary data being passed", () => {
+    const error = new ForbiddenError('My message', {
+      arbitrary: 'user_data',
+    });
+
+    expect(error.extensions).toEqual({
+      code: 'FORBIDDEN',
+      arbitrary: 'user_data',
+    });
+  })
+})
+
+describe("AuthenticationError", () => {
+  it("supports abritrary data being passed", () => {
+    const error = new AuthenticationError('My message', {
+      arbitrary: 'user_data',
+    });
+
+    expect(error.extensions).toEqual({
+      code: 'UNAUTHENTICATED',
+      arbitrary: 'user_data',
+    });
+  })
+})

packages/apollo-server-errors/src/index.ts

@@ -177,16 +177,16 @@ export class ValidationError extends ApolloError {
 }
 
 export class AuthenticationError extends ApolloError {
-  constructor(message: string) {
-    super(message, 'UNAUTHENTICATED');
+  constructor(message: string, extensions?: Record<string, any>) {
+    super(message, 'UNAUTHENTICATED', extensions);
 
     Object.defineProperty(this, 'name', { value: 'AuthenticationError' });
   }
 }
 
 export class ForbiddenError extends ApolloError {
-  constructor(message: string) {
-    super(message, 'FORBIDDEN');
+  constructor(message: string, extensions?: Record<string, any>) {
+    super(message, 'FORBIDDEN', extensions);
 
     Object.defineProperty(this, 'name', { value: 'ForbiddenError' });
   }