Make web framework integrations into peer dependencies #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, have any sort of dependency at all on fastify (and fast-json-stringify!) from `apollo-server-fastify`. For now I've chosen the latest version for the peer dependencies because carefully researching "did every API we are using exist in [email protected]" seems like unnecessary work, but we can relax these later upon request. I think in practice this shouldn't affect how these packages are used because you should generally already be using your web framework in your app. Fixes #5210. See also #5139.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, have any sort of dependency at all on fastify (and
fast-json-stringify!) from
apollo-server-fastify.For now I've chosen the latest version for the peer dependencies because
carefully researching "did every API we are using exist in
[email protected]" seems like unnecessary work, but we can relax these later
upon request.
I think in practice this shouldn't affect how these packages are used
because you should generally already be using your web framework in your
app.
Fixes #5210. See also #5139.