-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Fastify 3 #5139
Comments
This is fixed on the |
Could you point to the test? |
Hi @glasser, did you consider adding |
I hope you mean |
That makes sense. I want to make sure I understand the choices we've made in our existing integration libraries about deps vs peer deps and am checking in with folks who worked on this project before me. |
Notably, have any sort of dependency at all on fastify (and fast-json-stringify!) from `apollo-server-fastify`. For now I've chosen the latest version for the peer dependencies because carefully researching "did every API we are using exist in [email protected]" seems like unnecessary work, but we can relax these later upon request. I think in practice this shouldn't affect how these packages are used because you should generally already be using your web framework in your app. Fixes #5210. See also #5139.
Notably, have any sort of dependency at all on fastify (and fast-json-stringify!) from `apollo-server-fastify`. For now I've chosen the latest version for the peer dependencies because carefully researching "did every API we are using exist in [email protected]" seems like unnecessary work, but we can relax these later upon request. I think in practice this shouldn't affect how these packages are used because you should generally already be using your web framework in your app. Fixes #5210. See also #5139.
Hi, the current plugin doesn't support fastify 3.
Reproduction: Follow https://github.com/apollographql/apollo-server/tree/main/packages/apollo-server-fastify
On server start:
Response when calling the playground:
GET query missing.
There are some open issues but it looks like that there is no progress. What's the current status?
Related: #4356, #4463
The text was updated successfully, but these errors were encountered: